Allow Doctrine Event manager v2 #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Coder264
commented
Feb 20, 2023
| @@ -13,7 +13,7 @@ | |||
| "doctrine/collections": "^1.6", | |||
| "doctrine/common": "^3.1", | |||
| "doctrine/dbal": "^2.13 || ^3.0", | |||
| "doctrine/event-manager": "^1.1", | |||
| "doctrine/event-manager": "^1.2 || ^2.0", | |||
There was a problem hiding this comment.
The 1.1 to 1.2 bump is needed in order to be able to have code that is compatible with both v1 and v2 at the same time (the getAllListeners method call to be more specific).
VincentLanglet
approved these changes
Feb 20, 2023
|
Thanks ! Do you need a release for this ? |
|
@VincentLanglet Thanks for the merge. I'm in no hurry for a release for this, though #543 probably warrants a release once it's merged. |
|
#543 is merged too. I can make a release, unless you have other PR in mind before |
|
@VincentLanglet I have one more PR in mind, will be sending it in today. |
|
@VincentLanglet Here it is, even sooner than I expected 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is a backwards compatible change.
Changelog